Skip to content

Conversation

@monkey0506
Copy link
Owner

@monkey0506 monkey0506 commented Apr 18, 2023

Removed diagnostic NGD1002 (marshalParamsAs argument must be array of correct length) reported when marshalParamsAs argument (e.g., to FromAction or FromFunctionPointer) contained a different number of elements than arguments needed for the native generic delegate (e.g., the number of arguments passed to Invoke).

If excessive MarshalAsAttribute elements are provided in the array argument, they are ignored. If too few elements are provided, then the remainder are treated as null.

Closes #5.

@monkey0506 monkey0506 added the enhancement New feature or request label Apr 18, 2023
@monkey0506 monkey0506 added this to the v2.0.0 milestone Apr 18, 2023
@monkey0506 monkey0506 self-assigned this Apr 18, 2023
@monkey0506 monkey0506 linked an issue Apr 18, 2023 that may be closed by this pull request
@monkey0506 monkey0506 marked this pull request as ready for review April 18, 2023 01:49
@monkey0506 monkey0506 merged commit ef339d9 into incremental-generator Apr 18, 2023
@monkey0506 monkey0506 deleted the remove-diagnostic-ngd1002 branch April 18, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Diagnostic NGD1002 can be removed

2 participants